[google_maps_flutter] Fix custom marker icons on iOS#10993
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Feb 10, 2026
Merged
[google_maps_flutter] Fix custom marker icons on iOS#10993auto-submit[bot] merged 2 commits intoflutter:mainfrom
auto-submit[bot] merged 2 commits intoflutter:mainfrom
Conversation
stuartmorgan-g
requested review from
LongCatIsLooong and
vashworth
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a regression in custom marker icon handling on iOS. The change modifies the memory management of the assetProvider property in FLTGroundOverlaysController and FLTMarkersController from weak to strong. This ensures the asset provider is not deallocated prematurely. The PR also introduces new tests to verify the correct retention of the asset provider and updates the package version and changelog.
vashworth
approved these changes
Feb 10, 2026
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 11, 2026
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 11, 2026
flutter/packages@091acc5...1e50195 2026-02-10 20989940+aednlaxer@users.noreply.github.com [google_maps_flutter_web] Add Advanced markers support (web) (flutter/packages#9773) 2026-02-10 louisehsu@google.com [google_sign_in_ios][UIScene] Migrate to UIScene (flutter/packages#10960) 2026-02-10 stuartmorgan@google.com [google_maps_flutter] Fix custom marker icons on iOS (flutter/packages#10993) 2026-02-10 engine-flutter-autoroll@skia.org Roll Flutter from e8f9dc5 to 9bda20a (34 revisions) (flutter/packages#10992) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #10863 I intermediated asset loading through an asset loader, so that individual controllers weren't using the plugin registrar directly. In doing that, I just updated the types of the ivars, but—incorrectly—not their memory models.
Registrar references are generally
weakto avoid possible cycles (the registrar may internally be the same thing in the engine that owns the plugin instance), so the result was a weak reference to the new wrapper object. However, unlike the registrar, which has an externally enforced lifetime longer than the plugin, the wrapper was just an object created locally during map controller initialization, so was invalidated almost as soon as it was passed in. This fixes the controllers to keep strong references to the wrapper (which doesn't own anything, and has a weak registrar pointer, so can't create any cycles).Fixes flutter/flutter#182149
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3